security: enforce TLS certificate verification - #1563
Open
Alexandre Gattiker (algattik) wants to merge 4 commits into
Open
Alexandre Gattiker (algattik) wants to merge 4 commits into
Alexandre Gattiker (algattik) wants to merge 4 commits into
Conversation
- remove unverified privileged OSMO request - enforce Redis and NGINX certificate validation - add fail-closed TLS regression coverage Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ac45846-fda0-424f-912c-7c54e8a2ee93 🔒 - Generated by Copilot
Alexandre Gattiker (algattik)
requested a review
from a team
as a code owner
September 18, 2026 14:57
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 279 279
Lines 23203 23203
Branches 3199 3153 -46
=======================================
Hits 20444 20444
Misses 2071 2071
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Katrien De Graeve (katriendg)
left a comment
Katrien De Graeve (katriendg)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for hardening the TLS defaults and removing the privileged OSMO role mutation. I locally confirmed the focused tests, ShellCheck, rendered nginx configuration, and current CI state. I left two inline comments covering the user-facing HTTPS configuration contract and production-client behavioral coverage.
- verify Redis certificate hostnames before purge operations - exercise production clients and document HTTPS backend trust 🔒 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📚 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8f1e83a-6a5a-436d-8d39-bebdfe3d8ae4
🔀 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8f1e83a-6a5a-436d-8d39-bebdfe3d8ae4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Enforce TLS certificate and hostname verification for production OSMO, Redis, and Data Viewer connections. Remove the redundant privileged OSMO role mutation that bypassed certificate validation and add fail-closed regression coverage.
Closes #1562
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationData Viewer NGINX and security regression tests are also affected.
Testing Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Production-client TLS tests passed (5/5), including rendered NGINX and Redis certificate and hostname rejection. PSScriptAnalyzer, ShellCheck, Markdown lint, and spell checks passed.
All five OSMO E2E tests passed on test deployed instance: RL lifecycle, RL dataset training, IL lifecycle, VLA fine-tuning, and Azure ML replay.
Documentation Impact
Bug Fix Checklist
Checklist