test(dataviewer): make backend tests deterministic - #1601
Draft
Alexandre Gattiker (algattik) wants to merge 2 commits into
Draft
Alexandre Gattiker (algattik) wants to merge 2 commits into
Alexandre Gattiker (algattik) wants to merge 2 commits into
Conversation
- isolate datasets and external services with pytest fixtures - replace private and legacy patterns with public behavior - restore subprocess, loader, storage, and validation coverage 🧪 - Generated by Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31f89bdc-925b-401f-baab-20cc131db360
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 88.10% 88.30% +0.19%
==========================================
Files 279 279
Lines 23203 23203
Branches 3153 3153
==========================================
+ Hits 20444 20490 +46
+ Misses 2071 1978 -93
- Partials 688 735 +47
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
🔤 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16904c91-fd21-4efb-9909-c008f45ca45e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Refactor the dataviewer backend test suite around deterministic pytest fixtures and public behavior. External storage, media, model, and cloud boundaries use controlled fakes; temporary datasets replace repository-local data; shared fixtures move to
conftest.py; and exact API, persistence, fallback, and contract assertions replace legacy and implementation-coupled patterns.Closes #128
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationDataviewer backend tests under
data-management/viewer/backend/tests/are affected.Testing Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Documentation Impact
Bug Fix Checklist
Not applicable; this PR refactors tests without changing production behavior.
Checklist