Skip to content

fix(scripts): enforce LF line endings for shell scripts - #1609

Open
Jamie Kim (jkim323) wants to merge 3 commits into
mainfrom
fix/normalize-shell-line-endings
Open

Jamie Kim (jkim323) wants to merge 3 commits into
mainfrom
fix/normalize-shell-line-endings

Conversation

@jkim323

@jkim323 Jamie Kim (jkim323) commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Enforce LF checkouts for all tracked shell scripts, regardless of the contributor's
core.autocrlf setting. Make the root .gitattributes policy versionable by removing
its existing .gitignore entry.

Closes #1610

Type of Change

  • 🐛 Bug fix (non-breaking change fixing an issue)
  • ✨ New feature (non-breaking change adding functionality)
  • 💥 Breaking change (fix or feature causing existing functionality to change)
  • 📚 Documentation update
  • 🏗️ Infrastructure change (Terraform/IaC)
  • ♻️ Refactoring (no functional changes)

Component(s) Affected

  • infrastructure/terraform/prerequisites/ - Azure subscription setup
  • infrastructure/terraform/ - Terraform infrastructure
  • infrastructure/setup/ - OSMO control plane / Helm
  • workflows/ - Training and evaluation workflows
  • training/ - Training pipelines and scripts
  • docs/ - Documentation
  • Repository settings - shell script line-ending policy

Testing Performed

  • Terraform plan reviewed (no unexpected changes)
  • Terraform apply tested in dev environment
  • Training scripts tested locally with Isaac Sim
  • OSMO workflow submitted successfully
  • Smoke tests passed (smoke_test_azure.py)

Additional validation:

  • git diff --check origin/main...HEAD passed
  • All 95 tracked .sh files contain zero carriage-return bytes
  • All 95 tracked .sh worktree blobs match their index blobs
  • All 95 tracked .sh files resolve to text: set and eol: lf
  • VS Code workspace diagnostics report no errors

Documentation Impact

  • No documentation changes needed
  • Documentation updated in this PR
  • Documentation issue filed

Bug Fix Checklist

Complete this section for bug fix PRs. Skip for other contribution types.

  • Linked to issue being fixed
  • Regression test included, OR
  • Justification for no regression test: This change adds a declarative Git line-ending policy; repository-wide attribute, byte, and blob checks validate it without changing shell source content.

Checklist

@jkim323 Jamie Kim (jkim323) self-assigned this Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f3d3a76.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.10%. Comparing base (ccd7603) to head (f3d3a76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files         279      279           
  Lines       23203    23203           
  Branches     3199     3199           
=======================================
  Hits        20444    20444           
  Misses       2071     2071           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
go 100.00% <ø> (ø)
pester 86.64% <ø> (ø) Carriedforward from 02c8821
pytest-data-pipeline 100.00% <ø> (ø) Carriedforward from 02c8821
pytest-dataviewer 89.66% <ø> (ø) Carriedforward from 02c8821
pytest-dm-tools 100.00% <ø> (ø) Carriedforward from 02c8821
pytest-evaluation 95.40% <ø> (ø)
pytest-fuzz 3.99% <ø> (ø) Carriedforward from 02c8821
pytest-inference 100.00% <ø> (ø) Carriedforward from 02c8821
pytest-shared-ci 100.00% <ø> (ø) Carriedforward from 02c8821
pytest-training 92.60% <ø> (ø) Carriedforward from 02c8821
vitest 85.66% <ø> (ø) Carriedforward from 02c8821
vitest-app 85.66% <ø> (ø) Carriedforward from 02c8821
vitest-components 85.66% <ø> (ø) Carriedforward from 02c8821
vitest-features 85.66% <ø> (ø) Carriedforward from 02c8821
vitest-lib 85.66% <ø> (ø) Carriedforward from 02c8821
vitest-state 85.66% <ø> (ø) Carriedforward from 02c8821

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkim323
Jamie Kim (jkim323) requested a review from a team September 20, 2026 05:30
@jkim323
Jamie Kim (jkim323) force-pushed the fix/normalize-shell-line-endings branch from 09b351c to 6cb9b74 Compare September 20, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(scripts): enforce LF line endings for shell scripts

2 participants