fix(data): improve Viewer accessible interactions - #1641
Open
Bill Berry (WilliamBerryiii) wants to merge 6 commits into
Open
Bill Berry (WilliamBerryiii) wants to merge 6 commits into
Bill Berry (WilliamBerryiii) wants to merge 6 commits into
Conversation
- expose state, focus, status, and cancellation behavior - align language validation and generated API docs - preserve responsive interaction semantics ♿ - Generated by Copilot
- verify keyboard, status, pointer, language, and adaptive behavior - cover generated API documentation routes ♿ - Generated by Copilot
- add semantic Playwright inventory and deterministic fixtures - exercise adaptive Viewer, Swagger, and ReDoc workflows - pin the browser test runtime ♿ - Generated by Copilot
Bill Berry (WilliamBerryiii)
requested a review
from a team
as a code owner
September 22, 2026 02:50
…/viewer-interactions # Conflicts: # data-management/viewer/frontend/src/components/__tests__/LabelPanel.test.tsx # data-management/viewer/frontend/src/components/annotation-panel/LabelPanel.tsx # data-management/viewer/specifications/language-tag-corpus.json
Bill Berry (WilliamBerryiii)
changed the base branch from
main
to
accessibility/viewer-data-integrity
September 22, 2026 03:31
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## accessibility/viewer-data-integrity #1641 +/- ##
=======================================================================
- Coverage 87.84% 87.83% -0.01%
=======================================================================
Files 281 281
Lines 23534 23508 -26
Branches 3193 3188 -5
=======================================================================
- Hits 20673 20648 -25
+ Misses 2150 2149 -1
Partials 711 711
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
…ity' into accessibility/viewer-interactions
…ity' into accessibility/viewer-interactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Improve Dataset Viewer accessibility across keyboard selection, pointer cancellation, focus visibility, language validation, status announcements, and generated API documentation. Add a 28-case semantic Playwright manifest and focused component coverage for the changed interaction behavior.
Closes #1636
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationDataset Viewer frontend, Viewer specifications, and generated API documentation behavior are affected.
Testing Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Targeted local validation:
npm --prefix data-management/viewer run validate:frontend: typecheck passed; ESLint reported 0 errors and 38 existing warnings; 1,672 tests passed across 146 files.git diff --check origin/main...accessibility/viewer-interactions: passed.Documentation Impact
Bug Fix Checklist
Complete this section for bug fix PRs. Skip for other contribution types.
Checklist