update titiler/titiler-pgstac #252
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
May 15, 2025
| colormap=colormap, | ||
| render_params=render_params, | ||
| reader_params=reader_params, | ||
| env=env, | ||
| ) | ||
| return result | ||
|
|
||
|
|
||
| # /tiles endpoint compat with titiler<0.15, Optional `tileMatrixSetId` |
There was a problem hiding this comment.
I've added this because I thought we needed default WebMercatorQuad tilematrixset back.
We can remove if not needed
There was a problem hiding this comment.
Let's keep it, I see in our logs that we do have callers that request tiles without a TMS in the path.
For others, you can verify with this query in pc-api-appinsights:
ProductionRequests
| where name == "GET" and service == "tiler"
| where not(url has "/preview.png")
| where url has "item/tiles" and not(url has "tiles/WebMercatorQuad")
vincentsarago
commented
May 15, 2025
| @@ -115,57 +115,74 @@ def mosaic_info( | |||
| def tile_routes( # type: ignore | |||
| request: Request, | |||
| search_id=Depends(pgstac_mosaic_factory.path_dependency), | |||
| tile=Depends(TmsTileParams), | |||
There was a problem hiding this comment.
TmsTileParams is not used anymore in titiler-pgstac so it might disappear 🙈
|
The CI/CD pipeline for this repo is functional. Once you pass the pipeline and merge this into main, it will be deployed and available at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
TODO