chore: restart browser if page closed manually #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debs-obrien
approved these changes
Mar 25, 2025
yury-s
reviewed
Mar 25, 2025
| async stop() { | ||
| await this._server.close(); | ||
| await this._page?.context()?.browser()?.close(); | ||
| await this._context.close(); |
Member
There was a problem hiding this comment.
Why don't we close browser anymore and who does it instead?
Member
Author
There was a problem hiding this comment.
This is server's stop, current implementation is CLI-only, so the process will self-destruct upon detach.
yury-s
approved these changes
Mar 25, 2025
pavelfeldman
force-pushed
the
restart_browser
branch
from
38e24d0 to
2072ced
Compare
yury-s
approved these changes
Mar 25, 2025
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18