feat: browser_choose_file #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new synchronous file chooser tool to enable uploading files via the browser, addressing issue #31.
- Implements the browser_choose_file tool in common.ts using a zod schema for validation.
- Updates index.ts to include the new tool in both snapshot and screenshot tool lists.
- Extends the Context class in context.ts to listen for file chooser events and provide a method to submit files, and updates README.md with corresponding documentation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/common.ts | Added the chooseFile tool using a zod schema for file paths. |
| src/index.ts | Registered the chooseFile tool in both tool lists. |
| src/context.ts | Added event handling for file chooser events and submission. |
| README.md | Updated documentation to include information for browser_choose_file. |
Comments suppressed due to low confidence (1)
src/context.ts:81
- [nitpick] Consider providing a more descriptive error message in submitFileChooser to help with debugging when no file chooser is detected.
if (!this._fileChooser)
src/tools/utils.ts
Outdated
| const page = context.existingPage(); | ||
| await waitForCompletion(page, () => callback(page)); | ||
| return snapshot ? captureAriaSnapshot(page, status) : { | ||
| return snapshot ? captureAriaSnapshot(context, page, status) : { |
Member
There was a problem hiding this comment.
I'd clear the file chooser after the action.
pavelfeldman
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31.
Prompt used for testing:
This won't work for asynchronously opened filechoosers, but let's start with the synchronous variant. I also tested with including the file chooser open state in the snapshot, but that didn't give better results.
I also tested with OneDrive and WeTransfer, but somehow our ARIA snapshots for those pages are missing some elements that are crucial to locate the upload buttons.