Skip to content

chore: only include visible iframes, keep frame locators in own array #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 4 commits into from
Mar 27, 2025
Merged

chore: only include visible iframes, keep frame locators in own array #60

Skn0tt merged 4 commits into from
Mar 27, 2025

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Mar 27, 2025

As discussed:

  • hides invisible frames from snapshot
  • keep our own frame locator array, so we don't rely on page.frames() ordering to be stable

@Skn0tt Skn0tt requested a review from pavelfeldman March 27, 2025 18:48
@Skn0tt Skn0tt self-assigned this Mar 27, 2025
pavelfeldman
pavelfeldman approved these changes Mar 27, 2025
View reviewed changes
@Skn0tt Skn0tt merged commit f033213 into microsoft:main Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt @pavelfeldman