fix: tired URL parsing bug #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a URL parsing bug by ensuring that the URL constructor receives a proper base URL when req.headers.host is defined.
- Fixes URL parsing by providing an explicit protocol via "http://".
- Removes redundant host concatenation logic.
Comments suppressed due to low confidence (1)
src/program.ts:57
- Consider providing a fallback or additional validation for req.headers.host to avoid constructing a URL with an undefined host value, which may lead to runtime errors.
const url = new URL(req.url ?? '', `http://${req.headers.host}`);
mxschmitt
reviewed
Mar 28, 2025
| if (options.port) { | ||
| const sessions = new Map<string, SSEServerTransport>(); | ||
| const httpServer = http.createServer(async (req, res) => { | ||
| const url = new URL(req.url ?? '', `http://${req.headers.host}`); |
Contributor
There was a problem hiding this comment.
Suggested change
| const url = new URL(req.url ?? '', `http://${req.headers.host}`); | |
| const url = new URL(`http://${req.headers.host || 'localhost'}${req.url || ''}`;); |
what about this?
Member
Author
There was a problem hiding this comment.
this should be exactly the same, because req.url is always absolute.
Member
Author
It's hard to test, because apparently our current client doesn't pass the |
pavelfeldman
added a commit
that referenced
this pull request
Mar 28, 2025
This reverts commit edac6da.
pavelfeldman
added a commit
that referenced
this pull request
Mar 28, 2025
Reverts #70 I was working on a bigger change and this conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
When
req.headers.hostis defined, the URL parsing breaks because there's no protocol.