Skip to content

feat: large file uploads #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 13, 2022
Merged

feat: large file uploads #1255

merged 13 commits into from
Apr 13, 2022

Conversation

rwoll
Copy link
Member

@rwoll rwoll commented Apr 13, 2022 •
edited by mxschmitt
Loading

Ports:

Fixes #1211

rwoll
rwoll commented Apr 13, 2022
View reviewed changes
mxschmitt
mxschmitt reviewed Apr 13, 2022
View reviewed changes
playwright/_impl/_set_input_files_helpers.py Outdated
"Cannot set buffer larger than 50Mb, please write it to a file and pass its path instead."
)

has_large_file = list(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this does not check the upper file limits, lets do something like this instead?

any([os.stat(f).st_size > SIZE_LIMIT_IN_BYTES for f in files if isinstance(f, (str, Path))])

@rwoll rwoll marked this pull request as ready for review April 13, 2022 18:36
@rwoll rwoll merged commit dbb6cc6 into microsoft:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ports]: Backport client side changes
2 participants
@rwoll @mxschmitt