Skip to content

chore(deps): prepare deps for monorepo #13057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
258 changes: 258 additions & 0 deletions packages/playwright-core/src/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,258 @@
module.exports = {
'browserServerImpl.ts': [ '**' ],

// CLI should only use client-side features.
'cli/': [
'cli/**',
'client/**',
'debug/injected/',
'generated/',
'grid/**',
'server/injected/',
'server/trace/**',
'utils/**',
],

'cli/driver.ts': [ '**' ],

// Client depends on chromium protocol for types.
'client/': [
'common/',
'protocol/',
'server/chromium/protocol.d.ts',
'utils/',
],

'dispatchers/': [
'common/',
'protocol/',
'server/**',
'utils/'
],

// Grid
'grid/': [
'client/',
'dispatchers/**',
'server/',
'utils/**',
],

'inProcessFactory.ts': [ '**' ],

'outofprocess.ts': [
'client/',
'protocol/',
'utils/'
],

'protocol/': [
'utils/'
],

// Generic dependencies for server-side code.
'server/': [
'common/',
'generated/',
'protocol/**',
// Can depend on any files in these subdirectories.
'server/',
// Can depend on files directly in the server directory.
'server/common/**',
'server/injected/**',
'server/supplements/**',
'utils/',
],

// No dependencies for code shared between node and page.
'server/common/': [],

// Strict dependencies for injected code.
'server/injected/': [
'server/common/', 'protocol/channels.ts'
],

// Electron and Clank use chromium internally.
'server/android/': [
'common/',
'generated/',
'protocol/',
'protocol/**',
'server/',
'server/chromium/',
'server/common/**',
'server/injected/**',
'server/supplements/**',
'utils/',
],

'server/browserContext.ts': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/common/**',
'server/injected/**',
'server/supplements/**',
'server/trace/recorder/tracing.ts',
'utils/',
],

'server/electron/': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/chromium/',
'server/common/**',
'server/injected/**',
'server/supplements/**',
'utils/',
],

'server/fetch.ts': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/common/**',
'server/injected/**',
'server/supplements/**',
'server/trace/recorder/tracing.ts',
'utils/',
],

'server/playwright.ts': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/android/',
'server/chromium/',
'server/common/**',
'server/electron/',
'server/firefox/',
'server/injected/**',
'server/supplements/**',
'server/webkit/',
'utils/',
],

'server/supplements/recorder/recorderApp.ts': [
'common/',
'server/',
'server/chromium/',
'utils/',
],

'server/supplements/recorderSupplement.ts': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/common/**',
'server/injected/**',
'server/snapshot/',
'server/supplements/**',
'utils/',
],


// Trace viewer
'server/trace/common/': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/common/**',
'server/injected/**',
'server/snapshot/',
'server/supplements/**',
'utils/',
],

'server/trace/recorder/': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/common/**',
'server/injected/**',
'server/snapshot/',
'server/supplements/**',
'server/trace/common/',
'utils/',
],

'server/trace/viewer/': [
'common/',
'generated/',
'protocol/**',
'server/',
'server/chromium/',
'server/common/**',
'server/injected/**',
'server/snapshot/',
'server/supplements/**',
'server/trace/common/',
'server/trace/recorder/',
'utils/',
],

// The service is a cross-cutting feature, and so it depends on a bunch of things.
'remote/': [
'client/',
'debug/',
'dispatchers/',
'server/',
'server/electron/',
'server/supplements/',
'server/trace/',
'utils/**',
],

'utils/': [
'common/',
'protocol/',
'third_party/diff_match_patch',
],

// Tracing is a client/server plugin, nothing should depend on it.
'web/components/': [
'third_party/highlightjs/**',
'web/third_party/vscode/',
],

'web/recorder/': [
'common/',
'server/supplements/recorder/recorderTypes.ts',
'web/',
'web/components/',
'web/third_party/vscode/',
],

'web/traceViewer/': [
'common/',
'protocol/callMetadata.ts',
'server/trace/common/',
'web/',
'web/third_party/vscode/',
'web/traceViewer/ui/',
],

'web/traceViewer/ui/': [
'common/',
'protocol/',
'protocol/channels.ts',
'server/snapshot/snapshotTypes.ts',
'server/trace/',
'server/trace/common/',
'server/trace/viewer/',
'third_party/**',
'web/',
'web/components/',
'web/traceViewer/',
],

'web/traceViewer/inMemorySnapshotter.ts': [ '**' ],
}
4 changes: 2 additions & 2 deletions packages/playwright-core/src/client/cdpSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

import * as channels from '../protocol/channels';
import { ChannelOwner } from './channelOwner';
import { Protocol } from '../server/chromium/protocol';
import * as api from '../../types/types';
import type { Protocol } from '../server/chromium/protocol';
import type * as api from '../../types/types';

export class CDPSession extends ChannelOwner<channels.CDPSessionChannel> implements api.CDPSession {
static from(cdpSession: channels.CDPSessionChannel): CDPSession {
Expand Down
17 changes: 17 additions & 0 deletions packages/playwright-test/src/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module.exports = {
'/': [
'reporters/',
'third_party/',
'matchers/',
],
'matchers': [
'expect.ts',
'globals.ts',
'testInfo.ts',
'types.ts',
'util.ts',
],
'reporters': [
'util.ts'
],
};
2 changes: 1 addition & 1 deletion packages/playwright-test/src/matchers/matchers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

import { Locator, Page, APIResponse } from 'playwright-core';
import { FrameExpectOptions } from 'playwright-core/lib/client/types';
import type { FrameExpectOptions } from 'playwright-core/lib/client/types';
import { constructURLBasedOnBaseURL } from 'playwright-core/lib/utils/utils';
import type { Expect } from '../types';
import { expectTypes, callLogText } from '../util';
Expand Down
Loading