feat: add missing slowMo to launchPersistentContext #1597
Conversation
JoelEinbinder
force-pushed
the
missing_slowmo
branch
from
040b0ed to
a60979b
Compare
src/server/chromium.ts
Outdated
| async launchPersistentContext(userDataDir: string, options: LaunchOptions = {}): Promise<BrowserContext> { | ||
| const { | ||
| timeout = 30000, | ||
| slowMo = undefined |
There was a problem hiding this comment.
nit: it should be ok to drop = undefined initialization and leave just slowMo
There was a problem hiding this comment.
Changed to = 0. I don't like destructing an optional value without a default. Feels like a bug to me at first glance, even though it isn't.
src/server/browserType.ts
Outdated
| wsEndpoint: string | ||
| } & BrowserOptions; | ||
|
|
||
| type BrowserOptions = { |
There was a problem hiding this comment.
I am personally lost in all these types. For example, I don't understand why BrowserOptions include slowMo. Can we just inline all the one-offs?
There was a problem hiding this comment.
I inlined BrowserOptions, and changed the types we export.
BrowserArgsOptions: For default args method
LaunchOptions: For the launch and launchPersistent methods
LaunchServerOptions: For launchServer and _launchServer methods
ConnectOptions: For connect method
Hopefully things are easier to follow now!
JoelEinbinder
force-pushed
the
missing_slowmo
branch
from
a60979b to
b5ab088
Compare
3 participants
slowMowas missing inlaunchPersistentContext, and I refactored the types a bit.