Skip to content

fix(webkit): allow fufilling requests to redirects #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoelEinbinder merged 1 commit into from
Apr 16, 2020
Merged

fix(webkit): allow fufilling requests to redirects #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webkit/wkInterceptableRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class WKInterceptableRequest implements network.RouteDelegate {
await this._interceptedPromise;

const base64Encoded = !!response.body && !helper.isString(response.body);
const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : undefined;
const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : '';

const responseHeaders: { [s: string]: string; } = {};
if (response.headers) {
Expand Down
3 changes: 1 addition & 2 deletions test/interception.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,7 @@ describe('Page.route', function() {
expect(response.ok()).toBe(true);
expect(intercepted).toBe(true);
});
// WebKit crashes. Firefox succeeds, but then fails to close.
it.fail(FFOX || WEBKIT)('should create a redirect', async({page, server}) => {
it('should create a redirect', async({page, server}) => {
await page.goto(server.PREFIX + '/empty.html');
await page.route('**/*', async(route, request) => {
if (request.url() !== server.PREFIX + '/redirect_this')
Expand Down