api(networkidle): remove networkidle2 #1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
ni2
branch
2 times, most recently
from
2a3e09e to
3e4e17e
Compare
dgozman
approved these changes
Apr 20, 2020
docs/api.md
Outdated
| - `options` <[Object]> Navigation parameters which might have the following properties: | ||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by using the [browserContext.setDefaultNavigationTimeout(timeout)](#browsercontextsetdefaultnavigationtimeouttimeout), [browserContext.setDefaultTimeout(timeout)](#browsercontextsetdefaulttimeouttimeout), [page.setDefaultNavigationTimeout(timeout)](#pagesetdefaultnavigationtimeouttimeout) or [page.setDefaultTimeout(timeout)](#pagesetdefaulttimeouttimeout) methods. | ||
| - `waitUntil` <"load"|"domcontentloaded"|"networkidle0"|"networkidle2"> When to consider navigation succeeded, defaults to `load`. Events can be either: | ||
| - `waitUntil` <"load"|"domcontentloaded"|"networkidle0"> When to consider navigation succeeded, defaults to `load`. Events can be either: |
Contributor
There was a problem hiding this comment.
It is networkidle0 here and networkidle below.
docs/ci.md
Outdated
| @@ -1,16 +1,19 @@ | |||
| # Getting started on CI | |||
| # Continuous integration.md | |||
docs/core-concepts.md
Outdated
| // Explicit text notation | ||
| await page.click('text="Login"'); | ||
| ```js | ||
| await page.click('css=article >> css=.bar > .baz >> css=span[attr=value]'); |
Contributor
There was a problem hiding this comment.
More realistic example is #free-month-promo >> text=Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1873