Skip to content

feat(chromium): roll to r782078 #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoelEinbinder merged 2 commits into from
Jul 1, 2020
Merged

feat(chromium): roll to r782078 #2714

JoelEinbinder merged 2 commits into from
Jul 1, 2020

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Jun 25, 2020

@JoelEinbinder
Copy link
Contributor Author

JoelEinbinder commented Jun 25, 2020

With no-preference being removed from the spec, maybe we should start throwing on this api. I'd expect Firefox to stop supporting this value soon. This seems like a breaking change for us, but I'd argue that it's a breaking change for the web which is actually a feature for us.

@JoelEinbinder JoelEinbinder merged commit e480ec3 into microsoft:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

@aslushnikov aslushnikov Awaiting requested review from aslushnikov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @dgozman