browser(webkit): don't show context menus for headless windows #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JoelEinbinder merged 1 commit into microsoft:master from JoelEinbinder:webkit_win_context_menu

Jul 1, 2020

Contributor

JoelEinbinder commented Jun 29, 2020

I wasn't able to test this directly because my build imploded. But I made a small prototype and it seems to do the trick.

JoelEinbinder/webkit@df7bfbe


          browser(webkit): don't show context menus for headless windows

2ce53e7

JoelEinbinder requested a review from pavelfeldman

June 29, 2020 17:24

yury-s approved these changes

View reviewed changes

JoelEinbinder merged commit cd18047 into microsoft:master

aslushnikov added a commit to aslushnikov/playwright that referenced this pull request


          browser(webkit): revert microsoft#2755

e31cf3f

Review URL: aslushnikov/WebKit@7d35d22

This reverts https://github.com/microsoft/playwright/pull/2755/files
Reason:
- it doesn't compile on Windows

aslushnikov added a commit that referenced this pull request


          browser(webkit): revert #2755 (#2809)

43cdb3b

Review URL: aslushnikov/WebKit@7d35d22

This reverts https://github.com/microsoft/playwright/pull/2755/files
Reason:
- it doesn't compile on Windows

References #2699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet