Skip to content

revert: testrunner: make environment a simple class (#2769) #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
Jul 1, 2020
Merged

revert: testrunner: make environment a simple class (#2769) #2790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/browsercontext.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

const utils = require('./utils');
const {FFOX, CHROMIUM, WEBKIT, MAC} = utils.testOptions(browserType);
const {FFOX, CHROMIUM, WEBKIT, MAC, CHANNEL} = utils.testOptions(browserType);

describe('BrowserContext', function() {
it('should create new context', async function({browser}) {
Expand Down Expand Up @@ -121,7 +121,7 @@ describe('BrowserContext', function() {
let error = await promise;
expect(error.message).toContain('Context closed');
});
it('close() should be callable twice', async({browser}) => {
it.fail(CHANNEL)('close() should be callable twice', async({browser}) => {
const context = await browser.newContext();
await Promise.all([
context.close(),
Expand Down
250 changes: 0 additions & 250 deletions test/environments.js
View file
Open in desktop

This file was deleted.

9 changes: 7 additions & 2 deletions test/page.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
const path = require('path');
const util = require('util');
const vm = require('vm');
const {FFOX, CHROMIUM, WEBKIT, WIN} = require('./utils').testOptions(browserType);
const {FFOX, CHROMIUM, WEBKIT, WIN, CHANNEL} = require('./utils').testOptions(browserType);

describe('Page.close', function() {
it('should reject all promises when page is closed', async({context}) => {
Expand Down Expand Up @@ -154,7 +154,7 @@ describe.fail(FFOX && WIN)('Page.Events.Crash', function() {
const error = await promise;
expect(error.message).toContain('Navigation failed because page crashed');
});
it('should be able to close context when page crashes', async({page}) => {
it.fail(CHANNEL)('should be able to close context when page crashes', async({page}) => {
await page.setContent(`<div>This page should crash</div>`);
crash(page);
await page.waitForEvent('crash');
Expand Down Expand Up @@ -1306,3 +1306,8 @@ describe('Page api coverage', function() {
});
});

describe.skip(!CHANNEL)('Page channel', function() {
it('page should be client stub', async({page, server}) => {
expect(!!page._channel).toBeTruthy();
});
});
Loading