fix(utility): create utility world when web security is disabled #31458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jun 27, 2024
| const guid = createGuid(); | ||
| this.source = `(() => { | ||
| globalThis.__pwInitScripts = globalThis.__pwInitScripts || {}; | ||
| const hasInitScript = globalThis.__pwInitScripts[${JSON.stringify(guid)}]; |
Member
There was a problem hiding this comment.
Suggested change
| const hasInitScript = globalThis.__pwInitScripts[${JSON.stringify(guid)}]; | |
| const hasInitScript = globalThis.__pwInitScripts['${guid}']; |
Here and below?
Member
Author
There was a problem hiding this comment.
I like JSON.stringify for consistency and safety when concating scripts.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"10 flaky28397 passed, 649 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts previous attempt at #31096
Fixes: #31431
Fixes: #31442