Skip to content

docs(selectors): fix selector register example #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Jul 29, 2020
Merged

docs(selectors): fix selector register example #3169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3679,7 +3679,7 @@ const { selectors, firefox } = require('playwright'); // Or 'chromium' or 'webk

const browser = await firefox.launch();
const page = await browser.newPage();
await page.goto('https://example.com');
await page.setContent(`<div><button>Click me</button></div>`);

// Use the selector prefixed with its name.
const button = await page.$('tag=button');
Expand Down
8 changes: 4 additions & 4 deletions test/workers.jest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ describe('Workers', function() {
});
it('should evaluate', async function({page}) {
const workerCreatedPromise = page.waitForEvent('worker');
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
const worker = await workerCreatedPromise;
expect(await worker.evaluate('1+1')).toBe(2);
});
it('should report errors', async function({page}) {
const errorPromise = new Promise(x => page.on('pageerror', x));
page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`
setTimeout(() => {
// Do a console.log just to check that we do not confuse it with an error.
console.log('hey');
Expand All @@ -77,7 +77,7 @@ describe('Workers', function() {
it('should clear upon navigation', async function({server, page}) {
await page.goto(server.EMPTY_PAGE);
const workerCreatedPromise = page.waitForEvent('worker');
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
const worker = await workerCreatedPromise;
expect(page.workers().length).toBe(1);
let destroyed = false;
Expand All @@ -89,7 +89,7 @@ describe('Workers', function() {
it('should clear upon cross-process navigation', async function({server, page}) {
await page.goto(server.EMPTY_PAGE);
const workerCreatedPromise = page.waitForEvent('worker');
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
const worker = await workerCreatedPromise;
expect(page.workers().length).toBe(1);
let destroyed = false;
Expand Down
2 changes: 1 addition & 1 deletion utils/generate_types/test/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ playwright.chromium.launch().then(async browser => {
page.on('console', message => {
console.log(message.text());
});
page.evaluate(() => console.log(5, 'hello', { foo: 'bar' }));
await page.evaluate(() => console.log(5, 'hello', { foo: 'bar' }));

{
const result = await page.evaluate(() => {
Expand Down