Skip to content

fix(webkit): ensure WebKit can play h264 video #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 6 commits into from
Aug 3, 2020
Merged

fix(webkit): ensure WebKit can play h264 video #3272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a14570
fix(webkit): ensure WebKit can play h264 video
yury-s Aug 3, 2020
a2414c4
Add new file
yury-s Aug 3, 2020
a47c343
Update test message
yury-s Aug 3, 2020
5fa866a
Restore movie.ogv
yury-s Aug 3, 2020
8f4d205
Use GHA v1.4.4
yury-s Aug 3, 2020
4e897a6
Revert "Use GHA v1.4.4"
yury-s Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/docker/Dockerfile.bionic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
RUN apt-get update && apt-get install -y --no-install-recommends \
libgstreamer-gl1.0-0 \
libgstreamer-plugins-bad1.0-0 \
gstreamer1.0-plugins-good
gstreamer1.0-plugins-good \
gstreamer1.0-libav

# 4. Install Chromium dependencies
RUN apt-get update && apt-get install -y --no-install-recommends \
Expand Down
15 changes: 15 additions & 0 deletions test/assets/video_mp4.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<html>
<body>

<video width="400" controls>
<source src="movie.mp4" type="video/mp4">
Your browser does not support h.264 HTML video.
</video>

<p>
Video courtesy of
<a href="https://www.bigbuckbunny.org/" target="_blank">Big Buck Bunny</a>.
</p>

</body>
</html>
7 changes: 5 additions & 2 deletions test/capabilities.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,14 @@ it.fail(WEBKIT && WIN)('should play video', async({page}) => {
// TODO: the test passes on Windows locally but fails on GitHub Action bot,
// apparently due to a Media Pack issue in the Windows Server.
//
// Safari only plays mp4 so we test WebKit with an .mp4 clip.
const fileName = WEBKIT ? 'video_mp4.html' : 'video.html';
const absolutePath = path.join(ASSETS_DIR, fileName);
// Our test server doesn't support range requests required to play on Mac,
// so we load the page using a file url.
const url = WIN
? 'file:///' + path.join(ASSETS_DIR, 'video.html').replace(/\\/g, '/')
: 'file://' + path.join(ASSETS_DIR, 'video.html');
? 'file:///' + absolutePath.replace(/\\/g, '/')
: 'file://' + absolutePath;
await page.goto(url);
await page.$eval('video', v => v.play());
await page.$eval('video', v => v.pause());
Expand Down