Skip to content

chore(test): use pathToFileURL #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 2 commits into from
Aug 5, 2020
Merged

chore(test): use pathToFileURL #3292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac183f
chore(test): use pathToFileURL
yury-s Aug 4, 2020
28f94fe
rebase
yury-s Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/capabilities.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

const path = require('path');
const url = require('url');

const {FFOX, CHROMIUM, WEBKIT, WIN, LINUX, ASSETS_DIR} = testOptions;

Expand Down Expand Up @@ -58,10 +59,7 @@ it.fail(WEBKIT && WIN)('should play video', async({page}) => {
const absolutePath = path.join(ASSETS_DIR, fileName);
// Our test server doesn't support range requests required to play on Mac,
// so we load the page using a file url.
const url = WIN
? 'file:///' + absolutePath.replace(/\\/g, '/')
: 'file://' + absolutePath;
await page.goto(url);
await page.goto(url.pathToFileURL(absolutePath).href);
await page.$eval('video', v => v.play());
await page.$eval('video', v => v.pause());
});
5 changes: 0 additions & 5 deletions test/navigation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@
* limitations under the License.
*/

const utils = require('./utils');
const path = require('path');
const url = require('url');
const {FFOX, CHROMIUM, WEBKIT, ASSETS_DIR, MAC, WIN} = testOptions;

it('should work with _blank target', async({page, server}) => {
server.setRoute('/empty.html', (req, res) => {
res.end(`<a href="${server.EMPTY_PAGE}" target="_blank">Click me</a>`);
Expand Down
5 changes: 1 addition & 4 deletions test/page-history.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/

const utils = require('./utils');
const path = require('path');
const url = require('url');
const {FFOX, CHROMIUM, WEBKIT, ASSETS_DIR, MAC, WIN} = testOptions;
Expand Down Expand Up @@ -56,9 +55,7 @@ it('page.goBack should work with HistoryAPI', async({page, server}) => {

it.fail(WEBKIT && MAC)('page.goBack should work for file urls', async ({page, server}) => {
// WebKit embedder fails to go back/forward to the file url.
const url1 = WIN
? 'file:///' + path.join(ASSETS_DIR, 'empty.html').replace(/\\/g, '/')
: 'file://' + path.join(ASSETS_DIR, 'empty.html');
const url1 = url.pathToFileURL(path.join(ASSETS_DIR, 'empty.html')).href;
const url2 = server.EMPTY_PAGE;
await page.goto(url1);
await page.setContent(`<a href='${url2}'>url2</a>`);
Expand Down