chore: make refs & emitGeneric private for mcp #35888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
May 7, 2025
|
|
||
| Generate `generic` aria nodes for elements w/o roles (similar to Chrome DevTools). | ||
|
|
||
| ### option: Locator.ariaSnapshot.ref |
There was a problem hiding this comment.
Please add to the breaking changes list.
| @@ -1976,13 +1976,7 @@ Frame: | |||
| ariaSnapshot: | |||
| parameters: | |||
| selector: string | |||
| ref: boolean? | |||
| emitGeneric: boolean? | |||
| mode: | |||
| @@ -746,11 +748,11 @@ it('ref mode can be used to stitch all frame snapshots', async ({ page, server } | |||
| expect(await allFrameSnapshot(page)).toContainYaml(` | |||
| - iframe [ref=s1e3]: | |||
| - iframe [ref=s1e3]: | |||
| - text: Hi, I'm frame | |||
| - generic [ref=s1e3]: Hi, I'm frame | |||
There was a problem hiding this comment.
did this change because ref is now bundled with emitGeneric?
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 failed 3 flaky39143 passed, 803 skipped Merge workflow run. |
yury-s
approved these changes
May 8, 2025
| @@ -38,7 +38,7 @@ import LiteYouTube from '@site/src/components/LiteYouTube'; | |||
| ### Miscellaneous | |||
|
|
|||
| - New option [`option: APIRequest.newContext.maxRedirects`] in [`method: APIRequest.newContext`] to control the maximum number of redirects. | |||
| - New option [`option: Locator.ariaSnapshot.ref`] in [`method: Locator.ariaSnapshot`] to generate reference for each element in the snapshot which can later be used to locate the element. | |||
| - New option `ref` in [`method: Locator.ariaSnapshot`] to generate reference for each element in the snapshot which can later be used to locate the element. | |||
There was a problem hiding this comment.
Maybe delete this section completely, there is no such option anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.