Skip to content

chore: remove protocol recordHar option in favor of explicit harStart #36030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented May 21, 2025

This simplifies things a bit, and makes it explicitly compatible with multiclient.

Drive-by: do not send har path to the server, it is a client-only concept.

References #35987.

This comment has been minimized.

This simplifies things a bit, and makes it explicitly compatible
with multiclient.
@dgozman dgozman force-pushed the chore-record-har branch from 423e920 to 1d874eb Compare May 21, 2025 14:54
Copy link
Contributor

Test results for "tests 1"

4 failed
❌ [playwright-test] › reporter-html.spec.ts:2859:5 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2
❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension

6 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39203 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants