Skip to content

chore: add some progress apis #36189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 4, 2025

This introduces:

  • progress.pause() and progress.resume() to implement expect one-shot logic;
  • progress.setCustomErrorHandler() to implement expect error handling.

This is a preparation to moving progress higher up the stack to the dispatcher.

References #35987.

This introduces:
- `progress.pause()` and `progress.resume()` to implement
  expect one-shot logic;
- `progress.setCustomErrorHandler()` to implement expect
  error handling.

This is a preparation to moving progress higher up the stack
to the dispatcher.
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Test results for "tests 1"

5 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-update.spec.ts:202:5 › should update test locations @macos-latest-node18-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:433:5 › page screenshot › should take fullPage screenshots during navigation @webkit-ubuntu-22.04-node18

39295 passed, 818 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant