Skip to content

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Nov 19, 2025

Closes #38265. I had trouble reproducing it in a test, but writing onto the Context value is never a good idea, so let's always use a copy.

@Skn0tt Skn0tt requested a review from dgozman November 19, 2025 14:07
@Skn0tt Skn0tt self-assigned this Nov 19, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "MCP"

2432 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-2

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-2`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:659 › should indicate current test status `@macos-latest-node18-2`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:659 › should indicate current test status `@windows-latest-node18-2`

40316 passed, 787 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit d92591a into microsoft:main Nov 19, 2025
33 of 34 checks passed
jchip pushed a commit to jchip/playwright that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: speedboard "prev/next" doesn't work

2 participants