Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/client/channelOwner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ export abstract class ChannelOwner<T extends channels.Channel = channels.Channel
return obj.addListener;
if (prop === 'removeEventListener')
return obj.removeListener;
if (prop === 'domain') // https://github.com/microsoft/playwright/issues/3848
return obj.domain;
return (params: any) => this._connection.sendMessageToServer(this._type, guid, String(prop), params);
},
});
Expand Down
22 changes: 21 additions & 1 deletion test/channels.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,21 @@
* limitations under the License.
*/

import { it, expect, options } from './playwright.fixtures';
import domain from 'domain';
import { it, expect, options, playwrightFixtures } from './playwright.fixtures';
import type { ChromiumBrowser } from '..';

playwrightFixtures.defineWorkerFixture('domain', async ({ }, test) => {
const local = domain.create();
local.run(() => { });
let err;
local.on('error', e => err = e);
local.enter();
await test(null);
if (err)
throw err;
});

it('should work', async ({browser}) => {
expect(!!browser['_connection']).toBeTruthy();
});
Expand Down Expand Up @@ -144,6 +156,14 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions})
await expectScopeState(browserType, GOLDEN_PRECONDITION);
});

it('should work with the domain module', async ({ domain, browserType }) => {
const browser = await browserType.launch();
const page = await browser.newPage();
const result = await page.evaluate(() => 1 + 1);
expect(result).toBe(2);
await browser.close();
});

async function expectScopeState(object, golden) {
golden = trimGuids(golden);
const remoteState = trimGuids(await object._channel.debugScopeState());
Expand Down
1 change: 1 addition & 0 deletions test/playwright.fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type PlaywrightWorkerFixtures = {
browserType: BrowserType<Browser>;
browser: Browser;
httpService: {server: TestServer, httpsServer: TestServer}
domain: void;
toImpl: (rpcObject: any) => any;
isChromium: boolean;
isFirefox: boolean;
Expand Down