Skip to content

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Dec 22, 2025

Closes: #38550

Co-authored-by: Pavel Feldman <[email protected]>
Signed-off-by: Chris <[email protected]>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@pavelfeldman
Copy link
Member

@cpAdm sorry we can't link from generic methods to JS-specific methods in the docs. Otherwise links are broken.

@cpAdm
Copy link
Contributor Author

cpAdm commented Dec 24, 2025

@cpAdm sorry we can't link from generic methods to JS-specific methods in the docs. Otherwise links are broken.

It doesn't even make sense for other languages than JS to mention toString, fixed this by having separate documentation.

This however showed a new error:

============================
ERROR: missing documentation:
Documented "Locator.toString" not found in sources

Had to adjust missingDocs.js a little for that. Note that both ElementHandle and JSHandle still have undocumented toString methods.

@github-actions
Copy link
Contributor

Test results for "MCP"

2727 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20-2`

34401 passed, 689 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Expose locator.toString() type/docs

2 participants