fix(listeners): avoid "too many listeners" problem #3931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
approved these changes
Sep 21, 2020
Contributor
JoelEinbinder
left a comment
JoelEinbinder
left a comment
There was a problem hiding this comment.
It seems like having too many pages is the kind of leak that "too many listeners" is trying to warn about. But I guess if you have that many pages open, you will be aware of it.
We currently spawn a process per page when recording video in Chromium. This triggers "too many listeners" on the process object once you have enough pages open.
pavelfeldman
added a commit
to pavelfeldman/playwright
that referenced
this pull request
Oct 23, 2020
…#3931)" This holds on to process / handlers forever.
pavelfeldman
added a commit
that referenced
this pull request
Oct 23, 2020
aslushnikov
pushed a commit
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently spawn a process per page when recording
video in Chromium. This triggers "too many listeners" on the
process object once you have enough pages open.