Skip to content

test: minor fixes #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aslushnikov merged 2 commits into from
Oct 1, 2020
Merged

test: minor fixes #4024

aslushnikov merged 2 commits into from
Oct 1, 2020

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Sep 30, 2020 •
edited
Loading

  • missing await
  • missing defaultBrowserOptions that's important to respect FFPATH (and other custom browsers)

@aslushnikov aslushnikov force-pushed the test-fixtures-do-not-clash-between-workers branch from 51f51dd to 330f296 Compare October 1, 2020 00:03
@aslushnikov aslushnikov changed the title test: do not clash output directories between multiple workers test: minor fixes Oct 1, 2020
@aslushnikov aslushnikov merged commit b9dcfb9 into microsoft:master Oct 1, 2020
@aslushnikov aslushnikov deleted the test-fixtures-do-not-clash-between-workers branch October 1, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslushnikov @pavelfeldman