Skip to content

test: run crash tests with chromium wire #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Oct 1, 2020
Merged

test: run crash tests with chromium wire #4026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions test/page-event-crash.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function crash(page, toImpl, browserName) {
}

describe('', (suite, { browserName, platform, wire }) => {
suite.fixme(wire);
suite.skip(wire && browserName !== 'chromium');
suite.flaky(browserName === 'firefox' && platform === 'win32');
}, () => {
it('should emit crash event when page crashes', async ({page, browserName, toImpl}) => {
Expand Down Expand Up @@ -63,10 +63,7 @@ describe('', (suite, { browserName, platform, wire }) => {
expect(error.message).toContain('Navigation failed because page crashed');
});

it('should be able to close context when page crashes', (test, { browserName, platform, wire }) => {
test.fixme(wire);
test.flaky(browserName === 'firefox' && platform === 'win32');
}, async ({page, browserName, toImpl}) => {
it('should be able to close context when page crashes', async ({page, browserName, toImpl}) => {
await page.setContent(`<div>This page should crash</div>`);
crash(page, toImpl, browserName);
await page.waitForEvent('crash');
Expand Down