fix(video): wait for videos when closing persistent context #4040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Oct 2, 2020
To achieve this, we close all the pages one by one, then wait for the videos to finish processing, and then close the browser.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Nov 1, 2022
Previously, we closed pages one by one before closing the browser when shutting down the persistent context. This logic was introduced in microsoft#4040 to properly finish video recordings in persistent context. Such a process makes it unnecessary brittle to close the persistent context. For example, Chromium headless is sometimes unable to close the last persistent page for unknown reasons. Instead, we can just stop video recordings manually and close the browser right away.
dgozman
added a commit
that referenced
this pull request
Nov 1, 2022
Previously, we closed pages one by one before closing the browser when shutting down the persistent context. This logic was introduced in #4040 to properly finish video recordings in persistent context. Such a process makes it unnecessary brittle to close the persistent context. For example, Chromium headless is sometimes unable to close the last persistent page for unknown reasons. Instead, we can just stop video recordings manually and close the browser right away. Fixes #18229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve this, we close all the pages one by one, then wait for the videos to finish processing, and then close the browser.
Drive-by: fixes a bug where we did not delete downloads from persistent context.
References #3996.