Skip to content

chore(typo): resolve typo in src/progress.ts #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Oct 5, 2020
Merged

chore(typo): resolve typo in src/progress.ts #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/server/progress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class ProgressController {
private _state: 'before' | 'running' | 'aborted' | 'finished' = 'before';
private _deadline: number = 0;
private _timeout: number = 0;
private _logRecordring: string[] = [];
private _logRecording: string[] = [];
private _listener?: (result: ProgressResult) => Promise<void>;

constructor() {
Expand Down Expand Up @@ -88,7 +88,7 @@ export class ProgressController {
aborted: this._abortedPromise,
log: message => {
if (this._state === 'running')
this._logRecordring.push(message);
this._logRecording.push(message);
debugLogger.log(this._logName, message);
},
timeUntilDeadline: () => this._deadline ? this._deadline - monotonicTime() : 2147483647, // 2^31-1 safe setTimeout in Node.
Expand Down Expand Up @@ -117,10 +117,10 @@ export class ProgressController {
await this._listener({
startTime,
endTime: monotonicTime(),
logs: this._logRecordring,
logs: this._logRecording,
});
}
this._logRecordring = [];
this._logRecording = [];
return result;
} catch (e) {
this._aborted();
Expand All @@ -131,15 +131,15 @@ export class ProgressController {
await this._listener({
startTime,
endTime: monotonicTime(),
logs: this._logRecordring,
logs: this._logRecording,
error: e,
});
}
rewriteErrorMessage(e,
e.message +
formatLogRecording(this._logRecordring) +
formatLogRecording(this._logRecording) +
kLoggingNote);
this._logRecordring = [];
this._logRecording = [];
throw e;
}
}
Expand Down