docs: add videos to verification doc #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Oct 6, 2020
docs/verification.md
Outdated
| // With browser.newContext | ||
| const context = await browser.newContext({ videosPath: 'videos/' }); | ||
|
|
||
| // With browser.newPage |
Contributor
There was a problem hiding this comment.
Suggested change
| // With browser.newPage | |
| // With browser.newPage() |
docs/verification.md
Outdated
| Playwright can record videos for all pages in a [browser context](core-concepts.md#browser-contexts). | ||
|
|
||
| ```js | ||
| // With browser.newContext |
Contributor
There was a problem hiding this comment.
nit: demonstrates that its a function
Suggested change
| // With browser.newContext | |
| // With browser.newContext() |
dgozman
approved these changes
Oct 7, 2020
docs/verification.md
Outdated
| // [Optional] Specify video size; defaults to viewport size | ||
| const context = await browser.newContext({ | ||
| videosPath: 'videos/', | ||
| videoSize: { width: 1920, height: 1080 } |
Contributor
There was a problem hiding this comment.
nit: I'd go for something smaller here 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3996