Skip to content

test: roll test runner 0.9.22 #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
Oct 6, 2020
Merged

test: roll test runner 0.9.22 #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"ws": "^7.3.1"
},
"devDependencies": {
"@playwright/test": "0.9.9",
"@playwright/test-runner": "0.9.20",
"@playwright/test": "0.9.10",
"@playwright/test-runner": "0.9.22",
"@types/debug": "^4.1.5",
"@types/extract-zip": "^1.6.2",
"@types/mime": "^2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion test/chromium/oopif.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe('oopif', (suite, { browserName }) => {
await page.goto(server.PREFIX + '/dynamic-oopif.html');
expect(page.frames().length).toBe(2);
expect(await countOOPIFs(browser)).toBe(1);
expect(await page.screenshot()).toMatchImage('screenshot-oopif.png', { threshold: 0.3 });
expect(await page.screenshot()).toMatchSnapshot('screenshot-oopif.png', { threshold: 0.3 });
});

it('should load oopif iframes with subresources and route', async function({browser, page, server, context}) {
Expand Down
28 changes: 14 additions & 14 deletions test/elementhandle-screenshot.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('element screenshot', (suite, parameters) => {
await page.evaluate(() => window.scrollBy(50, 100));
const elementHandle = await page.$('.box:nth-of-type(3)');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-bounding-box.png');
expect(screenshot).toMatchSnapshot('screenshot-element-bounding-box.png');
});

it('should take into account padding and border', async ({page}) => {
Expand All @@ -49,7 +49,7 @@ describe('element screenshot', (suite, parameters) => {
`);
const elementHandle = await page.$('div#d');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-padding-border.png');
expect(screenshot).toMatchSnapshot('screenshot-element-padding-border.png');
});

it('should capture full element when larger than viewport in parallel', async ({page}) => {
Expand All @@ -75,7 +75,7 @@ describe('element screenshot', (suite, parameters) => {
const elementHandles = await page.$$('div.to-screenshot');
const promises = elementHandles.map(handle => handle.screenshot());
const screenshots = await Promise.all(promises);
expect(screenshots[2]).toMatchImage('screenshot-element-larger-than-viewport.png');
expect(screenshots[2]).toMatchSnapshot('screenshot-element-larger-than-viewport.png');

await verifyViewport(page, 500, 500);
});
Expand All @@ -102,7 +102,7 @@ describe('element screenshot', (suite, parameters) => {
`);
const elementHandle = await page.$('div.to-screenshot');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-larger-than-viewport.png');
expect(screenshot).toMatchSnapshot('screenshot-element-larger-than-viewport.png');

await verifyViewport(page, 500, 500);
});
Expand All @@ -128,7 +128,7 @@ describe('element screenshot', (suite, parameters) => {
`);
const elementHandle = await page.$('div.to-screenshot');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-scrolled-into-view.png');
expect(screenshot).toMatchSnapshot('screenshot-element-scrolled-into-view.png');
});

it('should scroll 15000px into view', async ({page}) => {
Expand All @@ -152,7 +152,7 @@ describe('element screenshot', (suite, parameters) => {
`);
const elementHandle = await page.$('div.to-screenshot');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-scrolled-into-view.png');
expect(screenshot).toMatchSnapshot('screenshot-element-scrolled-into-view.png');
});

it('should work with a rotated element', async ({page}) => {
Expand All @@ -166,7 +166,7 @@ describe('element screenshot', (suite, parameters) => {
transform: rotateZ(200deg);">&nbsp;</div>`);
const elementHandle = await page.$('div');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-rotate.png');
expect(screenshot).toMatchSnapshot('screenshot-element-rotate.png');
});

it('should fail to screenshot a detached element', async ({page, server}) => {
Expand Down Expand Up @@ -201,14 +201,14 @@ describe('element screenshot', (suite, parameters) => {
expect(done).toBe(false);
await elementHandle.evaluate(e => e.style.visibility = 'visible');
const screenshot = await promise;
expect(screenshot).toMatchImage('screenshot-element-bounding-box.png');
expect(screenshot).toMatchSnapshot('screenshot-element-bounding-box.png');
});

it('should work for an element with fractional dimensions', async ({page}) => {
await page.setContent('<div style="width:48.51px;height:19.8px;border:1px solid black;"></div>');
const elementHandle = await page.$('div');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-fractional.png');
expect(screenshot).toMatchSnapshot('screenshot-element-fractional.png');
});

it('should work with a mobile viewport', (test, { browserName }) => {
Expand All @@ -220,7 +220,7 @@ describe('element screenshot', (suite, parameters) => {
await page.evaluate(() => window.scrollBy(50, 100));
const elementHandle = await page.$('.box:nth-of-type(3)');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-mobile.png');
expect(screenshot).toMatchSnapshot('screenshot-element-mobile.png');
await context.close();
});

Expand All @@ -233,15 +233,15 @@ describe('element screenshot', (suite, parameters) => {
await page.evaluate(() => window.scrollBy(50, 100));
const elementHandle = await page.$('.box:nth-of-type(3)');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-mobile-dsf.png');
expect(screenshot).toMatchSnapshot('screenshot-element-mobile-dsf.png');
await context.close();
});

it('should work for an element with an offset', async ({page}) => {
await page.setContent('<div style="position:absolute; top: 10.3px; left: 20.4px;width:50.3px;height:20.2px;border:1px solid black;"></div>');
const elementHandle = await page.$('div');
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-fractional-offset.png');
expect(screenshot).toMatchSnapshot('screenshot-element-fractional-offset.png');
});

it('should take screenshots when default viewport is null', async ({server, browser}) => {
Expand Down Expand Up @@ -373,7 +373,7 @@ describe('element screenshot', (suite, parameters) => {
return new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)));
});
const screenshot = await elementHandle.screenshot();
expect(screenshot).toMatchImage('screenshot-element-bounding-box.png');
expect(screenshot).toMatchSnapshot('screenshot-element-bounding-box.png');
});

it('should take screenshot of disabled button', async ({page}) => {
Expand All @@ -391,6 +391,6 @@ describe('element screenshot', (suite, parameters) => {
const elementHandle = await page.$('.box:nth-of-type(3)');
const outputPath = testInfo.outputPath(path.join('these', 'are', 'directories', 'screenshot.png'));
await elementHandle.screenshot({path: outputPath});
expect(await fs.promises.readFile(outputPath)).toMatchImage('screenshot-element-bounding-box.png');
expect(await fs.promises.readFile(outputPath)).toMatchSnapshot('screenshot-element-bounding-box.png');
});
});
4 changes: 2 additions & 2 deletions test/emulation-focus.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ it('should not affect screenshots', (test, { browserName, headful }) => {
page.screenshot(),
page2.screenshot(),
]);
expect(screenshots[0]).toMatchImage('screenshot-sanity.png');
expect(screenshots[1]).toMatchImage('grid-cell-0.png');
expect(screenshots[0]).toMatchSnapshot('screenshot-sanity.png');
expect(screenshots[1]).toMatchSnapshot('grid-cell-0.png');
});

it('should change focused iframe', async ({page, server}) => {
Expand Down
Loading