browser(firefox): a different way to emit 'load' event #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Oct 7, 2020
package-lock.json
Outdated
| "dev": true, | ||
| "optional": true | ||
| }, | ||
| "bindings": { |
Member
There was a problem hiding this comment.
Is it intended to be a part of this PR?
dgozman
approved these changes
Oct 7, 2020
aslushnikov
force-pushed
the
fff-new-way-to-emit-load-event
branch
from
2ddb2f2 to
c889071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using WebProgressListener events works in all cases. Currently
used
pageshowevent will stop being emitted in future when loadingwas stopped with
window.stop()api.References #3995