fix: disable chromium sandbox by default #4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain environments, e.g. Azure Pipelines, override default user inside container with a custom one, whereas fail to pass proper seccomp profile for the docker image. As a result, chromium sandboxing fails. To ease life of devops deploying tests in various CI's, this patch disables Chromium sandbox by default. References microsoft#4084
pavelfeldman
approved these changes
Oct 7, 2020
Member
pavelfeldman
left a comment
pavelfeldman
left a comment
There was a problem hiding this comment.
Please mark this as a breaking change in the release notes.
mxschmitt
reviewed
Oct 8, 2020
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
can we remove the logic which enabled automatically the sandbox if the user is root?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain environments, e.g. Azure Pipelines, override default user
inside container with a custom one, whereas fail to pass proper
seccomp profile for the docker image.
As a result, chromium sandboxing fails.
To ease life of devops deploying tests in various CI's, this patch
disables Chromium sandbox by default.
References #4084