feat: tap #4097
Merged
feat: tap #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Oct 11, 2020
Contributor
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Do we have tests for tap? I assume we need good coverage, checking touch/pointer events, touchstart preventDefault and triggered mouse/click events.
JoelEinbinder
force-pushed
the
touchscreen_tap
branch
2 times, most recently
from
ba1fd79 to
0bf0f4f
Compare
dgozman
approved these changes
Oct 13, 2020
JoelEinbinder
force-pushed
the
touchscreen_tap
branch
from
0bf0f4f to
bc47109
Compare
JoelEinbinder
force-pushed
the
touchscreen_tap
branch
from
bc47109 to
717e75a
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently just the api and documentation. I'll add tests an impls as I finish them, but I think its easier to review this part independently.
Adds
page.touchscreen.tappage.tapframe.tapelementHandle.taphasTouchmust be enabled on the browser context level to use tap, otherwise it throws.Blocked on #4099, #4101 and #4102