Update getFromEnv logic to validate that value is undefined (instead of falsey) before redefining it
#4226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…d of falsey) before redefining it Additionally, cast the `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD` check to a number to allow for values of 0 or 1
majapw
force-pushed
the
maja-allow-for-skip-browser-download-override
branch
from
85ef481 to
90c9b23
Compare
majapw
changed the title
?? instead of || to allow for overriding of truthy values with falsey onesgetFromEnv logic to validate that value is undefined (instead of falsey) before redefining it
Member
|
Ouch, I did not see your change as I crafted mine. Let me actually cancel mine! |
Contributor
Author
|
No worries! Are the test failures expected flake? Also happy to make this a bit more robust. I was expecting only |
pavelfeldman
approved these changes
Oct 23, 2020
Member
We have a broken screencast test on the tip of the tree, should cycle green soon-ish.
That's Ok for now. I might follow up with respecting |
aslushnikov
pushed a commit
that referenced
this pull request
Oct 27, 2020
…nstead of falsey) before redefining it (#4226) Additionally, cast the `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD` check to a number to allow for values of 0 or 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, cast the
PLAYWRIGHT_SKIP_BROWSER_DOWNLOADcheck to a number to allow for values of 0 or 1Fix for #4225