Skip to content

chore: cleanup test logging on CI #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Mar 17, 2021
Merged

chore: cleanup test logging on CI #5848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 4 additions & 28 deletions test/downloads-path.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,49 +110,25 @@ it('should report downloads in downloadsPath folder', async ({downloadsBrowser,
});

it('should accept downloads in persistent context', async ({persistentDownloadsContext, testInfo, server}) => {
logOnCI('----- 1.1');
const page = persistentDownloadsContext.pages()[0];
logOnCI('----- 1.2');
const [ download ] = await Promise.all([
page.waitForEvent('download').then(d => {
logOnCI('----- 1.3');
return d;
}),
page.click('a').then(d => {
logOnCI('----- 1.4');
}),
page.waitForEvent('download'),
page.click('a'),
]);
logOnCI('----- 1.5');
expect(download.url()).toBe(`${server.PREFIX}/download`);
logOnCI('----- 1.6');
expect(download.suggestedFilename()).toBe(`file.txt`);
logOnCI('----- 1.7');
const path = await download.path();
logOnCI('----- 1.8');
expect(path.startsWith(testInfo.outputPath(''))).toBeTruthy();
logOnCI('----- 1.9');
});

it('should delete downloads when persistent context closes', async ({persistentDownloadsContext}) => {
logOnCI('----- 2.1');
const page = persistentDownloadsContext.pages()[0];
logOnCI('----- 2.2');
const [ download ] = await Promise.all([
page.waitForEvent('download').then(d => {
logOnCI('----- 2.3');
return d;
}),
page.click('a').then(() => {
logOnCI('----- 2.4');
}),
page.waitForEvent('download'),
page.click('a'),
]);
logOnCI('----- 2.5');
const path = await download.path();
logOnCI('----- 2.6');
expect(fs.existsSync(path)).toBeTruthy();
logOnCI('----- 2.7');
await persistentDownloadsContext.close();
logOnCI('----- 2.8');
expect(fs.existsSync(path)).toBeFalsy();
logOnCI('----- 2.9');
});