feat(firefox): roll Firefox to r1237 #5849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 17, 2021
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Looks like it merged with another PR.
|
|
||
| async _selectOption(progress: Progress, elements: ElementHandle[], values: types.SelectOption[], options: types.NavigatingActionWaitOptions): Promise<string[] | 'error:notconnected'> { | ||
| const optionsToSelect = [...elements, ...values]; | ||
| await progress.beforeInputAction(this); |
This patch rolls Firefox to r1237. Upstream firefox still struggles with crashes with certain videos: https://bugzilla.mozilla.org/show_bug.cgi?id=1697004 This PR also workarounds this crash by disabling webrender. References microsoft#5721
aslushnikov
force-pushed
the
roll-firefox-to-r1237
branch
from
19a89a4 to
7e341c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rolls Firefox to r1237. Upstream firefox still struggles
with crashes with certain videos: https://bugzilla.mozilla.org/show_bug.cgi?id=1697004
This PR also workarounds this crash by disabling webrender.
References #5721