chore(dotnet): improve name generation for objects #5860
Conversation
utils/doclint/generateDotnetApi.js
Outdated
| if (member.kind === 'method' || member.kind === 'property') { | ||
| // this should be easy to name... let's call it the same as the argument (eternal optimist) | ||
| let probableName = `${parent.name}${translateMemberName(``, name, null)}`; | ||
| if (specialNameResolutionMap.has(probableName)) |
There was a problem hiding this comment.
Like I mentioned in the chat it'd be nice if the list had only exceptions and most of the names would be generated in accord with some common rule (like ParamName or ClassParamName etc). While SelectOption looks like an exception Position could probably be derived by a common rule. We'll need this mapping at least in one more place - playwright.dev generator
There was a problem hiding this comment.
Yeah, that's a valid point.
I've gone and improved this so the names now being generated follow a logical rule. The only "special case" I had to add was for names that are too generic, like value, which gets translated to SelectOptionValue. But still, I'm much happier with this iteration.
avodovnik
changed the title
utils/doclint/generateDotnetApi.js
Outdated
| } | ||
| while (true) { | ||
| // crude attempt at removing plurality | ||
| if (attemptedName.endsWith('s')) |
There was a problem hiding this comment.
This is brittle, will fail on names like properties. Perhaps whitelist known names?
There was a problem hiding this comment.
It is, to some extent... But also, we only have a few of these that are actually plural, so I can work around with something like
if (attemptedName.endsWith('s') && !attemptedName === 'properties')
:-)
When we add something that'll break this simple logic, I can always revisit this... It's the same if I have to add a map entry, or a check, right?
2 participants
No description provided.