Skip to content

fix: work-around electron's broken event loop #5867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslushnikov merged 2 commits into from
Mar 18, 2021
Merged

fix: work-around electron's broken event loop #5867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae08d7
fix: work-around electron's broken event loop
aslushnikov Mar 18, 2021
aa07b4c
fix lint
aslushnikov Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ const mkdirAsync = util.promisify(fs.mkdir.bind(fs));

// See https://joel.tools/microtasks/
export function makeWaitForNextTask() {
// As of Mar 2021, Electorn v12 doesn't create new task with `setImmediate` despite
// using Node 14 internally, so we fallback to `setTimeout(0)` instead.
// @see https://github.com/electron/electron/issues/28261
if (process.versions.electron)
return callback => setTimeout(callback, 0);
if (parseInt(process.versions.node, 10) >= 11)
return setImmediate;

Expand Down