set system default python3 to python3.8 #5892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
reviewed
Mar 19, 2021
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Let's do the same in Docker.focal
|
|
Contributor
Author
|
@yury-s oh yeah, good call! |
yury-s
approved these changes
Mar 19, 2021
yury-s
reviewed
Mar 19, 2021
utils/docker/Dockerfile.bionic
Outdated
| update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \ | ||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 1 | ||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \ | ||
| update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \ |
utils/docker/Dockerfile.focal
Outdated
| update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \ | ||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 1 | ||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \ | ||
| update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \ |
yury-s
approved these changes
Mar 19, 2021
Contributor
Author
|
Sorted. Also this may be addressed faster by someone else anyway, I need to wait for our legal team to review the licence before I can sign the CLA. |
Member
|
Take your time and let us know if there are problems preventing you from committing this change, I or someone else could do it before the next release (likely next week). |
mxschmitt
approved these changes
Mar 19, 2021
Contributor
Author
|
👍 from legal, CLA signed. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5891.