Skip to content

Conversation

@kblok
Copy link
Contributor

@kblok kblok commented Apr 23, 2021

Having this doc:

### option: Browser.newContext.-inline- = %%-shared-context-params-list-%%

### option: Browser.newContext.proxy = %%-context-option-proxy-%%

### option: Browser.newContext.storageState = %%-js-python-context-option-storage-state-%%

### option: Browser.newContext.storageState = %%-csharp-java-context-option-storage-state-%%

### option: Browser.newContext.storageStatePath = %%-csharp-java-context-option-storage-state-path-%%

The inline elements were being pushed back in the list instead of honoring the position of the template in the main doc.

Copy link
Contributor

@avodovnik avodovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect many changes from this? Have you checked against the current baseline which files get modified?

@kblok
Copy link
Contributor Author

kblok commented Apr 23, 2021

Not many changes, @avodovnik. Only in NewContextAsync and NewPageAsync. You can take a look at it here https://github.com/microsoft/playwright-sharp/pull/1316/files#diff-830df37f7e83748f967f8fcbce73a543c3525c745e1f80f998db27992c322a92R184

@yury-s, do you think this could break Java?

@pavelfeldman
Copy link
Member

As long as our -inline- are only for the options, it should not break Java/Python!

@pavelfeldman pavelfeldman merged commit ba652c1 into microsoft:master Apr 30, 2021
@kblok kblok deleted the generator/inline-parsing branch May 1, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants