Skip to content

fix: do not close stream until all bytes have been read #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yury-s merged 9 commits into from
Apr 28, 2021
Merged

fix: do not close stream until all bytes have been read #6351

yury-s merged 9 commits into from
Apr 28, 2021

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Apr 28, 2021 •
edited
Loading

  • Readable.read() can return null multiple times before reaching end of stream. If its buffer is empty we have to wait for readable event before assuming that returned null means end of stream.
  • Added test for large zip download which exposed the issue

Fixes #6286

@yury-s yury-s changed the title test: add test for loarge zip download fix: do not close stream until all bytes have been read Apr 28, 2021
@yury-s yury-s merged commit 560bea5 into microsoft:master Apr 28, 2021
@yury-s yury-s deleted the test-win-donload branch April 28, 2021 21:54
@yury-s yury-s mentioned this pull request Apr 28, 2021
Closed
@RFC2109 RFC2109 mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

+1 more reviewer

@mxschmitt mxschmitt mxschmitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]ZIP file containing binaries will not be downloaded complete with WebKit

3 participants

@yury-s @dgozman @mxschmitt