browser(webkit): fix setOfflineMode #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTK/WPE tries to load error page if navigation in the offline mode fails. This unintended navigation is unexpected and shouldn't happen during automation.
yury-s
approved these changes
Jan 26, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Jan 26, 2020
This roll fixes flakiness for the `Interception.setOfflineMode should work` test. Follow-up to microsoft#656.
pavelfeldman
pushed a commit
that referenced
this pull request
Jan 26, 2020
This roll fixes flakiness for the `Interception.setOfflineMode should work` test. Follow-up to #656.
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review URL: aslushnikov/WebKit@d34592a
GTK/WPE tries to load error page if navigation in the offline mode
fails. This unintended navigation is unexpected and shouldn't happen
during automation.
This substitutes #608