fix(tracing): error handling #6888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
reviewed
Jun 4, 2021
pavelfeldman
reviewed
Jun 4, 2021
- Reject when ZipFile signals an error. - Make sure snapshotter does not save trace events after stop(). - Await pending blob writes on stop().
dgozman
force-pushed
the
tracing-errors-handling
branch
from
4adbf6f to
176e164
Compare
Contributor
|
Seems like it fixes the following flaky test too: https://github.com/microsoft/playwright-python/runs/2748148009#step:12:881 |
pavelfeldman
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop().stop().