Skip to content

docs(pom): fixed JS example which contained TS #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 2 commits into from
Jun 7, 2021
Merged

docs(pom): fixed JS example which contained TS #6917

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
404f000
docs(pom): fixed JS example which contained TS
mxschmitt Jun 4, 2021
3e632c4
Update docs/src/test-pom.md
mxschmitt Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/src/test-pom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ We will create a `PlaywrightDevPage` helper class to encapsulate common operatio
```js js-flavor=js
// playwright-dev-page.js
exports.PlaywrightDevPage = class PlaywrightDevPage {
constructor(page: Page) {
constructor(page) {
/** @type {import('playwright').Page} */
Copy link
Contributor

@dgozman dgozman Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop this line. JS means no types!

this.page = page;
}

Expand Down