fix(test-runner): do not require esModuleInterop=true #7100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pavelfeldman
left a comment
pavelfeldman
left a comment
There was a problem hiding this comment.
It is a little hard for me to assess the implications of this. It is a breaking change to our users?
Contributor
Author
Should not be in my opinion. By this change it works in both modes, without the default export support and with. I just moved a few lines from the 3rd-party package expect into our codebase. We have a bunch of tests which are running TSC internally and they are still passing. Without my change they were broken (and the tsconfig adjustment). |
Contributor
|
I'd like Joel to review this instead of me 😄 |
mxschmitt
force-pushed
the
bugfix/test-runner-expect-7099
branch
4 times, most recently
from
5d4ae3e to
41331f4
Compare
mxschmitt
force-pushed
the
bugfix/test-runner-expect-7099
branch
from
41331f4 to
2141c86
Compare
JoelEinbinder
approved these changes
Jun 14, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Jun 25, 2021
aslushnikov
added a commit
that referenced
this pull request
Jun 25, 2021
Cherry-Pick PR #7100 SHA a3a9cca Co-authored-by: Max Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have a
export = fooexport in place, which would requireesModuleInteroporallowSyntheticDefaultImports. This PR does workaround that, since its not a TypeScript default which confuses users.Fixes #7099