Skip to content

fix(test): unflake waitForSelector when browser closes test #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoelEinbinder merged 1 commit into from
Jan 30, 2020
Merged

fix(test): unflake waitForSelector when browser closes test #767

JoelEinbinder merged 1 commit into from
Jan 30, 2020

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Jan 30, 2020

The waitForSelector call might not have made it into the browser by the time we disconnect, resulting in a websocket error instead of a protocol error.

@JoelEinbinder JoelEinbinder requested a review from dgozman January 30, 2020 22:11
@JoelEinbinder JoelEinbinder merged commit 2b231c9 into microsoft:master Jan 30, 2020
@JoelEinbinder JoelEinbinder deleted the unflake_websocket_disconnect_test branch January 30, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @dgozman